Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 23531027: Replace directly use of DriveIntegrationService to drive::util::GetXxxByProfile. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
satorux1
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Replace directly use of DriveIntegrationService to drive::util::Get{DriveService,FileSystem}ByProfile. As preparation to start returning DriveIntegrationService instance always by DriveIntegrationServiceFactory::GetForProfile, this reduces its direct usage. BUG=284972 TEST=Ran unit_tests R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -17 lines) Patch
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 6 chunks +37 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hidehiko
This is based on 23523022. Thank you for your review in advance, - hidehiko
7 years, 3 months ago (2013-09-04 17:55:13 UTC) #1
satorux1
LGTM
7 years, 3 months ago (2013-09-05 01:38:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23531027/1
7 years, 3 months ago (2013-09-05 02:22:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82956
7 years, 3 months ago (2013-09-05 03:04:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23531027/1
7 years, 3 months ago (2013-09-05 03:07:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23531027/1
7 years, 3 months ago (2013-09-05 06:50:50 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=83090
7 years, 3 months ago (2013-09-05 07:21:35 UTC) #7
hidehiko
7 years, 3 months ago (2013-09-05 08:32:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r221367 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698