reviewbot/handlers/policy_checklist/modification_comment.txt - Issue 23531026: Remove the review bot app.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: reviewbot/handlers/policy_checklist/modification_comment.txt

Issue 23531026: Remove the review bot app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 When modifying an existing policy setting, please consider the following:

2

3 - Make sure the policy meta data is up-to-date, in particular

4 supported_on, and the feature flags.

5 - In general, don't change policy semantics in a way that is

6 incompatible (as determined by user/admin-visible behavior) with

7 previous semantics. In particular, consider that existing policy

8 deployments may affect both old and new browser versions, and both

9 should behave according to the admin's intentions.

10 - It is OK to expand semantics of policy values as long as the previous

11 policy description is compatible with the new behavior.

12 - It is OK to update feature implementations and the policy description

13 when Chrome changes as long as the intended effect of the policy

14 remains intact.

15 - The process for removing policies is to deprecate them first, wait a

16 few releases (if possible) and then remove them. Make sure you put the

17 deprecated flag if you deprecate a policy.

OLD	NEW