Issue 23531015: Make CSSHostRule.addRule() / deleteRule() arguments mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23531015: Make CSSHostRule.addRule() / deleteRule() arguments mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, tasak (please_use_google.com), arv (Not doing code reviews)

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, do-not-use, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make CSSHostRule.addRule() / deleteRule() arguments mandatory Make CSSHostRule.addRule() / deleteRule() arguments mandatory as per the specification: https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#css-host-rule-interface It is confusing otherwise what is supposed to happen when the arguments are omitted. Firefox / IE do not implement CSSHostRule yet. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157127

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -3 lines)			Patch
M	LayoutTests/fast/dom/shadow/css-hostrule-api.html	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/dom/shadow/css-hostrule-api-expected.txt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSHostRule.idl	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23531015/1

7 years, 3 months ago (2013-09-03 13:02:49 UTC) #5

Message was sent while issue was closed.

Change committed as 157127