Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23531013: Revert "ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the c… (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Revert "ConstantPoolSizeAt() should return number of Instructions instead, otherwise, some of the code will be treated as constant pool when printing code in ARM disassembler." This reverts commit r16419 for breaking the ARM simulator tests. TEST=mjsunit/regress/regress-2624 R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/arm/disasm-arm.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
7 years, 3 months ago (2013-08-30 07:30:23 UTC) #1
Michael Achenbach
On 2013/08/30 07:30:23, Benedikt Meurer wrote: > PTAL lgtm
7 years, 3 months ago (2013-08-30 07:42:21 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-30 08:16:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16441.

Powered by Google App Engine
This is Rietveld 408576698