Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 23531010: Ensure that Vector destruction always clears the buffer pointer. (Closed)

Created:
7 years, 3 months ago by Chris Evans
Modified:
7 years, 3 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Ensure that Vector destruction always clears the buffer pointer. This was previously the case, with the exception of inline-buffer Vectors in "inline storage" mode. In the process, some code cleanups were performed: - Removed unused releaseBuffer(). - Added a little LIKELY / UNLIKELY. - Removed a lot of redundant branches. - Less work and two removed branches from the destructor path. Saves 100KB from a GCC-compiled Chrome binary. No real difference on clang, which seems to inline very differently. BUG=270545 R=abarth@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -78 lines) Patch
M Source/wtf/Deque.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/wtf/Vector.h View 17 chunks +37 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Evans
7 years, 3 months ago (2013-08-30 03:43:46 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-08-30 07:11:10 UTC) #2
Tom Sepez
LGTM2.
7 years, 3 months ago (2013-08-30 18:05:13 UTC) #3
Chris Evans
7 years, 3 months ago (2013-08-30 19:11:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r157005 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698