Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: runtime/vm/object_test.cc

Issue 23531008: Last round of cleanups in exception handler, before going to the next stage. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 26938)
+++ runtime/vm/object_test.cc (working copy)
@@ -2387,10 +2387,10 @@
exception_handlers ^= ExceptionHandlers::New(kNumEntries);
const bool kNeedsStacktrace = true;
const bool kNoStacktrace = false;
- exception_handlers.SetHandlerInfo(0, -1, 20, kNeedsStacktrace);
- exception_handlers.SetHandlerInfo(1, 0, 30, kNeedsStacktrace);
- exception_handlers.SetHandlerInfo(2, -1, 40, kNoStacktrace);
- exception_handlers.SetHandlerInfo(3, 1, 150, kNoStacktrace);
+ exception_handlers.SetHandlerInfo(0, -1, 20, kNeedsStacktrace, false);
+ exception_handlers.SetHandlerInfo(1, 0, 30, kNeedsStacktrace, false);
+ exception_handlers.SetHandlerInfo(2, -1, 40, kNoStacktrace, true);
+ exception_handlers.SetHandlerInfo(3, 1, 150, kNoStacktrace, true);
extern void GenerateIncrement(Assembler* assembler);
Assembler _assembler_;
@@ -2409,10 +2409,12 @@
EXPECT_EQ(-1, info.outer_try_index);
EXPECT_EQ(20, handlers.HandlerPC(0));
EXPECT(handlers.NeedsStacktrace(0));
+ EXPECT(!handlers.HasCatchAll(0));
EXPECT_EQ(20, info.handler_pc);
EXPECT_EQ(1, handlers.OuterTryIndex(3));
EXPECT_EQ(150, handlers.HandlerPC(3));
EXPECT(!handlers.NeedsStacktrace(3));
+ EXPECT(handlers.HasCatchAll(3));
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698