core/fpdfdoc/cpdf_formfield_unittest.cpp - Issue 2353093002: Assert that dictionary can own the objects it is given.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_formfield_unittest.cpp

Issue 2353093002: Assert that dictionary can own the objects it is given. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_formfield_unittest.cpp

diff --git a/core/fpdfdoc/cpdf_formfield_unittest.cpp b/core/fpdfdoc/cpdf_formfield_unittest.cpp

index 7677f452847f4253c342ac34bc2fa3ca5cddfe95..d6feff971841617bf9fedbe5384e7dc6a95a5f15 100644

--- a/core/fpdfdoc/cpdf_formfield_unittest.cpp

+++ b/core/fpdfdoc/cpdf_formfield_unittest.cpp

@@ -26,7 +26,6 @@ TEST(cpdf_formfield, FPDF_GetFullName) {

EXPECT_STREQ("bar.foo", name.UTF8Encode().c_str());

CPDF_Dictionary* dict2 = new CPDF_Dictionary;

- obj_holder.AddIndirectObject(dict2);

dict1->SetFor("Parent", dict2);

name = FPDF_GetFullName(root);

EXPECT_STREQ("bar.foo", name.UTF8Encode().c_str());

« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp ('k') | no next file » | no next file with comments »