Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* fix: use quotation for goma_dir in gn gen --args=

BUG=621828
Committed: https://chromium.googlesource.com/chromium/tools/build/+/424ec9ab07f18f80afc6de959a5be09bf55eecb5

[tikuta, 2016-09-21 07:55:57]

tikuta@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, shinyak@chromium.org, ukai@chromium.org,
yyanagisawa@chromium.org

[tikuta, 2016-09-21 07:55:57]

tikuta@chromium.org changed required reviewers:
+ phajdan.jr@chromium.org

[tikuta, 2016-09-21 07:55:58]

I forgot to quote goma_dir in args of gn.

[tikuta, 2016-09-21 07:56:10]

The CQ bit was checked by tikuta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 07:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 08:00:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 08:00:22]

Dry run: This issue passed the CQ dry run.

[ukai, 2016-09-21 08:13:18]

lgtm

[tikuta, 2016-09-21 09:50:21]

tikuta@chromium.org changed reviewers:
+ dsansome@chromium.org, emso@chromium.org

[tikuta, 2016-09-21 09:50:21]

+emso, +dsansome

I can land this soon if ONWER give me LGTM.

[tikuta, 2016-09-21 09:57:34]

Description was changed from

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/

BUG=621828
==========

to

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* use quotation for goma_dir in gn gen --args=

BUG=621828
==========

[tikuta, 2016-09-21 09:59:14]

Description was changed from

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* use quotation for goma_dir in gn gen --args=

BUG=621828
==========

to

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* fix: use quotation for goma_dir in gn gen --args=

BUG=621828
==========

[shinyak, 2016-09-21 09:59:26]

lgtm

[emso, 2016-09-21 10:02:38]

lgtm

Sounds good. I'll review the OWNERS for this recipe. Currently, I can't approve
this.

[Paweł Hajdan Jr., 2016-09-21 19:08:39]

LGTM

[dsansome, 2016-09-22 02:21:19]

lgtm

[dsansome, 2016-09-22 08:15:41]

The CQ bit was checked by dsansome@chromium.org

[commit-bot: I haz the power, 2016-09-22 08:15:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 08:23:45]

Description was changed from

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* fix: use quotation for goma_dir in gn gen --args=

BUG=621828
==========

to

==========
Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

* use chromium.ensure_goma()
* modify gn args to use correct goma_dir

This is reland of https://codereview.chromium.org/2332283002/
* fix: use quotation for goma_dir in gn gen --args=

BUG=621828

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/424ec9ab07f18f80afc6...
==========

[commit-bot: I haz the power, 2016-09-22 08:23:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/424ec9ab07f18f80afc6...