Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3174)

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/Shell.java

Issue 2353063005: Refactor ContentViewClient (1/6) (Closed)
Patch Set: cast to activity Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/android/java/src/org/chromium/content_shell/Shell.java
diff --git a/content/shell/android/java/src/org/chromium/content_shell/Shell.java b/content/shell/android/java/src/org/chromium/content_shell/Shell.java
index 2151dbd9375592d96d64193090661290c0ca2cbb..7cc7a7261b451bc2eb7201aa8705fc9cad7be227 100644
--- a/content/shell/android/java/src/org/chromium/content_shell/Shell.java
+++ b/content/shell/android/java/src/org/chromium/content_shell/Shell.java
@@ -4,6 +4,7 @@
package org.chromium.content_shell;
+import android.app.Activity;
import android.content.Context;
import android.graphics.drawable.ClipDrawable;
import android.text.TextUtils;
@@ -22,6 +23,8 @@ import android.widget.TextView.OnEditorActionListener;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.content.browser.ActivityContentVideoViewEmbedder;
+import org.chromium.content.browser.ContentVideoViewEmbedder;
import org.chromium.content.browser.ContentView;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
@@ -287,7 +290,7 @@ public class Shell extends LinearLayout {
@CalledByNative
private void initFromNativeTabContents(WebContents webContents) {
Context context = getContext();
- mContentViewCore = new ContentViewCore(context);
+ mContentViewCore = new ContentViewCore(context, "");
ContentView cv = ContentView.createContentView(context, mContentViewCore);
mContentViewCore.initialize(ViewAndroidDelegate.createBasicDelegate(cv), cv,
webContents, mWindow);
@@ -306,6 +309,23 @@ public class Shell extends LinearLayout {
mContentViewRenderView.setCurrentContentViewCore(mContentViewCore);
}
+ @CalledByNative
+ public ContentVideoViewEmbedder getContentVideoViewEmbedder() {
+ return new ActivityContentVideoViewEmbedder((Activity) getContext()) {
+ @Override
+ public void enterFullscreenVideo(View view, boolean isVideoLoaded) {
+ super.enterFullscreenVideo(view, isVideoLoaded);
+ mContentViewRenderView.setOverlayVideoMode(true);
+ }
+
+ @Override
+ public void exitFullscreenVideo() {
+ super.exitFullscreenVideo();
+ mContentViewRenderView.setOverlayVideoMode(false);
+ }
+ };
+ }
+
/**
* Enable/Disable navigation(Prev/Next) button if navigation is allowed/disallowed
* in respective direction.

Powered by Google App Engine
This is Rietveld 408576698