Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 2353063005: Refactor ContentViewClient (1/6) (Closed)
Patch Set: cast to activity Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index c02a64547fa42a64b5da44e624bcd04d725dd365..c46bc99edebce91e5d31be0e82bbe846dc9bfd0d 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -214,14 +214,11 @@ MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
// small chunks of data.
RequestDecoderResources(media_player_params.player_id, true);
#if !defined(USE_AURA)
- ContentViewCoreImpl* content_view_core_impl =
- static_cast<ContentViewCoreImpl*>(
- ContentViewCore::FromWebContents(web_contents_));
- if (!content_view_core_impl) {
- extract_metadata = false;
+ if (WebContentsDelegate* delegate = web_contents_->GetDelegate()) {
+ should_block =
+ delegate->ShouldBlockMediaRequest(media_player_params.url);
} else {
- should_block = content_view_core_impl->ShouldBlockMediaRequest(
- media_player_params.url);
+ extract_metadata = false;
}
#endif
if (!extract_metadata) {
@@ -455,8 +452,16 @@ void BrowserMediaPlayerManager::OnEnterFullscreen(int player_id) {
gfx::Size(player->GetVideoWidth(), player->GetVideoHeight());
}
+ if (!web_contents()->GetDelegate())
+ return;
+
+ base::android::ScopedJavaLocalRef<jobject> embedder(
+ web_contents()->GetDelegate()->GetContentVideoViewEmbedder());
video_view_.reset(
- new ContentVideoView(this, GetContentViewCore(), natural_video_size));
+ new ContentVideoView(this,
+ GetContentViewCore(),
+ embedder,
+ natural_video_size));
base::android::ScopedJavaLocalRef<jobject> j_content_video_view =
video_view_->GetJavaObject(base::android::AttachCurrentThread());
« no previous file with comments | « content/browser/android/content_view_core_impl.cc ('k') | content/browser/media/android/browser_surface_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698