Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2842)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 2353063005: Refactor ContentViewClient (1/6) (Closed)
Patch Set: cast to activity Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index 36e994ba55d21c691d82a324083181729aaf0a66..d202dbffbe05f6b86e1c8dffb1548cdfefa197f2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -6,7 +6,6 @@ package org.chromium.chrome.browser.compositor.bottombar;
import android.app.Activity;
import android.content.Context;
-import android.view.View;
import android.view.View.MeasureSpec;
import org.chromium.base.ActivityState;
@@ -28,7 +27,6 @@ import org.chromium.chrome.browser.compositor.overlays.SceneOverlay;
import org.chromium.chrome.browser.compositor.scene_layer.SceneOverlayLayer;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
import org.chromium.chrome.browser.tab.Tab;
-import org.chromium.content.browser.ContentVideoViewEmbedder;
import org.chromium.content.browser.ContentViewClient;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content_public.common.TopControlsState;
@@ -405,27 +403,7 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
MeasureSpec.EXACTLY);
}
}
-
- @Override
- public ContentVideoViewEmbedder getContentVideoViewEmbedder() {
- // TODO(mdjones): Possibly enable fullscreen video in overlay panels rather than
- // passing an empty implementation.
- return new ContentVideoViewEmbedder() {
- @Override
- public void enterFullscreenVideo(View view, boolean isVideoLoaded) {}
-
- @Override
- public void fullscreenVideoLoaded() {}
-
- @Override
- public void exitFullscreenVideo() {}
-
- @Override
- public void setSystemUiVisibility(boolean enterFullscreen) {}
- };
- }
});
-
return content;
}

Powered by Google App Engine
This is Rietveld 408576698