chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java - Issue 2353063005: Refactor ContentViewClient (1/6)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

Issue 2353063005: Refactor ContentViewClient (1/6) (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsDelegateAndroid.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelEventFilterTest.java » ('j') | chrome/browser/android/tab_web_contents_delegate_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

index f3710ee425b7a8f8bdc40a6789b7f0ec3405b4d0..83b9e993aa9eaf54f57c7f3e0b725be4bd4c8ab3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java

@@ -121,7 +121,7 @@ public class VrShell extends GvrLayout implements GLSurfaceView.Renderer, VrShel

mUiVrWindowAndroid = new VrWindowAndroid(mActivity);

mUiContents = WebContentsFactory.createWebContents(true, false);

- mUiCVC = new ContentViewCore(mActivity);

+ mUiCVC = new ContentViewCore(mActivity, "");

boliu 2016/09/27 23:28:45 ditto, this one has to be wrong..

Jinsuk Kim 2016/09/28 03:58:52 ChromeVersionInfo.getProductVersion().

ContentView uiContentView = ContentView.createContentView(mActivity, mUiCVC);

mUiCVC.initialize(ViewAndroidDelegate.createBasicDelegate(uiContentView),

uiContentView, mUiContents, mUiVrWindowAndroid);