Refactor ContentViewClient (1/6)

content/browser/media/android/browser_media_player_manager.cc

Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index c02a64547fa42a64b5da44e624bcd04d725dd365..6ae0181e552a629ca3efde69df60f673b46bd031 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -214,15 +214,11 @@ MediaPlayerAndroid* BrowserMediaPlayerManager::CreateMediaPlayer(
           // small chunks of data.
           RequestDecoderResources(media_player_params.player_id, true);
 #if !defined(USE_AURA)
-      ContentViewCoreImpl* content_view_core_impl =
-          static_cast<ContentViewCoreImpl*>(
-              ContentViewCore::FromWebContents(web_contents_));
-      if (!content_view_core_impl) {
+      if (WebContentsDelegate* delegate = web_contents_->GetDelegate())

[boliu, 2016/09/26 21:25:25]

style: need braces if the body is more than one line

[Jinsuk Kim, 2016/09/27 10:08:59]

Done.

+        should_block =
+            delegate->ShouldBlockMediaRequest(media_player_params.url);
+      else
         extract_metadata = false;
-      } else {
-        should_block = content_view_core_impl->ShouldBlockMediaRequest(
-            media_player_params.url);
-      }
 #endif
       if (!extract_metadata) {
         // May reach here due to prerendering or throttling. Don't extract the
@@ -455,8 +451,13 @@ void BrowserMediaPlayerManager::OnEnterFullscreen(int player_id) {
         gfx::Size(player->GetVideoWidth(), player->GetVideoHeight());
   }
 
+  base::android::ScopedJavaLocalRef<jobject> embedder(
+      web_contents()->GetDelegate()->GetContentVideoViewEmbedder());

[boliu, 2016/09/26 21:25:25]

null check GetDelegate

[Jinsuk Kim, 2016/09/27 10:08:58]

Done.

   video_view_.reset(
-      new ContentVideoView(this, GetContentViewCore(), natural_video_size));
+      new ContentVideoView(this,
+                           GetContentViewCore(),
+                           embedder,
+                           natural_video_size));
 
   base::android::ScopedJavaLocalRef<jobject> j_content_video_view =
       video_view_->GetJavaObject(base::android::AttachCurrentThread());