Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: content/browser/android/content_video_view.h

Issue 2353063005: Refactor ContentViewClient (1/6) (Closed)
Patch Set: fix tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_video_view.h
diff --git a/content/browser/android/content_video_view.h b/content/browser/android/content_video_view.h
index 7efe33081f0ad8610c6a9ac841a7cfd88e66ab16..9440624b5ae4d63160ee242363a1e3b7a48622ed 100644
--- a/content/browser/android/content_video_view.h
+++ b/content/browser/android/content_video_view.h
@@ -14,6 +14,10 @@
#include "content/public/browser/android/content_view_core.h"
#include "ui/gl/android/scoped_java_surface.h"
+namespace web_contents_delegate_android {
boliu 2016/09/26 21:25:24 this is unused (also layering violation?)
Jinsuk Kim 2016/09/27 10:08:58 Done.
+class WebContentsDelegateAndroid;
+}
+
namespace content {
// Native mirror of ContentVideoView.java. This class is responsible for
@@ -46,6 +50,7 @@ class ContentVideoView {
explicit ContentVideoView(Client* client,
ContentViewCore* content_view_core,
+ const base::android::JavaRef<jobject>& embedder,
const gfx::Size& video_natural_size);
~ContentVideoView();
@@ -90,8 +95,10 @@ class ContentVideoView {
private:
// Creates the corresponding ContentVideoView Java object.
- JavaObjectWeakGlobalRef CreateJavaObject(ContentViewCore* content_view_core,
- const gfx::Size& video_natural_size);
+ JavaObjectWeakGlobalRef CreateJavaObject(
+ ContentViewCore* content_view_core,
+ const base::android::JavaRef<jobject>& j_content_video_view_embedder,
+ const gfx::Size& video_natural_size);
Client* client_;

Powered by Google App Engine
This is Rietveld 408576698