Refactor ContentViewClient (1/6)

content/public/browser/web_contents_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/browser/web_contents_delegate.h"
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/singleton.h"
 #include "build/build_config.h"
@@ skipping 190 matching lines @@
              << "Not supported.";
   return false;
 }
 
 #if defined(OS_ANDROID)
 void WebContentsDelegate::RequestMediaDecodePermission(
     WebContents* web_contents,
     const base::Callback<void(bool)>& callback) {
   callback.Run(false);
 }
+
+base::android::ScopedJavaLocalRef<jobject>
+WebContentsDelegate::GetContentVideoViewEmbedder() {
+  NOTREACHED() << "Implementation must be provided through subclass.";

[boliu, 2016/09/26 21:25:25]

generally content allow embedders to selectivey override methods, plus you
already have null checks I think, so just remove this line?

[Jinsuk Kim, 2016/09/27 10:08:59]

Should have been removed. Done.

+  return base::android::ScopedJavaLocalRef<jobject>();
+}
+
+bool WebContentsDelegate::ShouldBlockMediaRequest(const GURL& url) {
+  return false;
+}
 #endif
 
 bool WebContentsDelegate::RequestPpapiBrokerPermission(
     WebContents* web_contents,
     const GURL& url,
     const base::FilePath& plugin_path,
     const base::Callback<void(bool)>& callback) {
   return false;
 }
 
@@ skipping 37 matching lines @@
 void WebContentsDelegate::ShowCertificateViewerInDevTools(
     WebContents* web_contents,
     scoped_refptr<net::X509Certificate> certificate) {
 }
 
 void WebContentsDelegate::RequestAppBannerFromDevTools(
     content::WebContents* web_contents) {
 }
 
 }  // namespace content