Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2353063004: Add "MkKeyContext" KeyContext generation function. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add "MkKeyContext" KeyContext generation function. This function helps generate KeyContexts concisely in other packages, where direct struct initialization without field names will trigger linter complaints. BUG=None TEST=local - go test ./... - Tested `goapp test ./impl/prod` - Tested "impl/cloud" with "gcd.sh". R=iannucci@chromium.org Committed: https://github.com/luci/gae/commit/674c24e7256c2f71621475bc126a0b76508c4bf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -81 lines) Patch
M filter/dscache/serialize.go View 1 chunk +1 line, -1 line 0 comments Download
M filter/txnBuf/txnbuf_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_data.go View 3 chunks +5 lines, -5 lines 0 comments Download
M impl/memory/datastore_index.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_query_execution.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_query_execution_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/datastore_query_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M impl/memory/datastore_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/memory/testing_utils_test.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/prod/datastore_key.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/prod/raw_datastore_type_converter.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/checkfilter_test.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/context.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/context_test.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/datastore_test.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/key.go View 3 chunks +10 lines, -5 lines 0 comments Download
M service/datastore/key_test.go View 9 chunks +25 lines, -25 lines 0 comments Download
M service/datastore/properties_test.go View 1 chunk +1 line, -1 line 0 comments Download
M service/datastore/query_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M service/datastore/serialize/serialize_test.go View 12 chunks +27 lines, -27 lines 0 comments Download
M service/datastore/size_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
dnj
4 years, 3 months ago (2016-09-20 17:26:57 UTC) #1
iannucci
Told ya. lgtm
4 years, 3 months ago (2016-09-20 18:32:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353063004/1
4 years, 3 months ago (2016-09-20 20:36:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/gae/commit/674c24e7256c2f71621475bc126a0b76508c4bf0
4 years, 3 months ago (2016-09-20 20:42:07 UTC) #10
dnj
4 years, 3 months ago (2016-09-20 20:46:53 UTC) #11
Message was sent while issue was closed.
On 2016/09/20 18:32:44, iannucci wrote:
> Told ya.

I didn't claim otherwise, just noted that I couldn't reproduce the error within
luci/gae :)

Powered by Google App Engine
This is Rietveld 408576698