Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)
Patch Set: review comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 if (isHeapTimeline && WebInspector.moduleSetting("recordAllocationStacks").g et()) { 79 if (isHeapTimeline && WebInspector.moduleSetting("recordAllocationStacks").g et()) {
80 this._allocationDataGrid = new WebInspector.AllocationDataGrid(profile.t arget() , this); 80 this._allocationDataGrid = new WebInspector.AllocationDataGrid(profile.t arget() , this);
81 this._allocationDataGrid.addEventListener(WebInspector.DataGrid.Events.S electedNode, this._onSelectAllocationNode, this); 81 this._allocationDataGrid.addEventListener(WebInspector.DataGrid.Events.S electedNode, this._onSelectAllocationNode, this);
82 this._allocationWidget = this._allocationDataGrid.asWidget(); 82 this._allocationWidget = this._allocationDataGrid.asWidget();
83 this._allocationWidget.setMinimumSize(50, 25); 83 this._allocationWidget.setMinimumSize(50, 25);
84 84
85 this._allocationStackView = new WebInspector.HeapAllocationStackView(pro file.target()); 85 this._allocationStackView = new WebInspector.HeapAllocationStackView(pro file.target());
86 this._allocationStackView.setMinimumSize(50, 25); 86 this._allocationStackView.setMinimumSize(50, 25);
87 87
88 this._tabbedPane = new WebInspector.TabbedPane(); 88 this._tabbedPane = new WebInspector.TabbedPane();
89 this._tabbedPane.headerElement().classList.add("heap-object-details-head er");
90 } 89 }
91 90
92 this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid(t his); 91 this._retainmentDataGrid = new WebInspector.HeapSnapshotRetainmentDataGrid(t his);
93 this._retainmentWidget = this._retainmentDataGrid.asWidget(); 92 this._retainmentWidget = this._retainmentDataGrid.asWidget();
94 this._retainmentWidget.setMinimumSize(50, 21); 93 this._retainmentWidget.setMinimumSize(50, 21);
95 this._retainmentWidget.element.classList.add("retaining-paths-view"); 94 this._retainmentWidget.element.classList.add("retaining-paths-view");
96 95
97 var splitWidgetResizer; 96 var splitWidgetResizer;
98 if (this._allocationStackView) { 97 if (this._allocationStackView) {
99 this._tabbedPane = new WebInspector.TabbedPane(); 98 this._tabbedPane = new WebInspector.TabbedPane();
100 this._tabbedPane.headerElement().classList.add("heap-object-details-head er");
101 99
102 this._tabbedPane.appendTab("retainers", WebInspector.UIString("Retainers "), this._retainmentWidget); 100 this._tabbedPane.appendTab("retainers", WebInspector.UIString("Retainers "), this._retainmentWidget);
103 this._tabbedPane.appendTab("allocation-stack", WebInspector.UIString("Al location stack"), this._allocationStackView); 101 this._tabbedPane.appendTab("allocation-stack", WebInspector.UIString("Al location stack"), this._allocationStackView);
104 102
105 splitWidgetResizer = this._tabbedPane.headerElement(); 103 splitWidgetResizer = this._tabbedPane.headerElement();
106 this._objectDetailsView = this._tabbedPane; 104 this._objectDetailsView = this._tabbedPane;
107 } else { 105 } else {
108 var retainmentViewHeader = createElementWithClass("div", "heap-snapshot- view-resizer"); 106 var retainmentViewHeader = createElementWithClass("div", "heap-snapshot- view-resizer");
109 var retainingPathsTitleDiv = retainmentViewHeader.createChild("div", "ti tle"); 107 var retainingPathsTitleDiv = retainmentViewHeader.createChild("div", "ti tle");
110 var retainingPathsTitle = retainingPathsTitleDiv.createChild("span"); 108 var retainingPathsTitle = retainingPathsTitleDiv.createChild("span");
(...skipping 2139 matching lines...) Expand 10 before | Expand all | Expand 10 after
2250 name.textContent = WebInspector.beautifyFunctionName(frame.functionN ame); 2248 name.textContent = WebInspector.beautifyFunctionName(frame.functionN ame);
2251 if (frame.scriptId) { 2249 if (frame.scriptId) {
2252 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ; 2250 var urlElement = this._linkifier.linkifyScriptLocation(this._tar get, String(frame.scriptId), frame.scriptName, frame.line - 1, frame.column - 1) ;
2253 frameDiv.appendChild(urlElement); 2251 frameDiv.appendChild(urlElement);
2254 } 2252 }
2255 } 2253 }
2256 }, 2254 },
2257 2255
2258 __proto__: WebInspector.Widget.prototype 2256 __proto__: WebInspector.Widget.prototype
2259 } 2257 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698