Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2353033004: [DevTools] Expose left and right toolbar in TabbedPane. (Closed)
Patch Set: review comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 /** @type {!WebInspector.NetworkLogView} */ 75 /** @type {!WebInspector.NetworkLogView} */
76 this._networkLogView = new WebInspector.NetworkLogView(this._filterBar, this ._progressBarContainer, this._networkLogLargeRowsSetting); 76 this._networkLogView = new WebInspector.NetworkLogView(this._filterBar, this ._progressBarContainer, this._networkLogLargeRowsSetting);
77 this._networkLogView.show(this._searchableView.element); 77 this._networkLogView.show(this._searchableView.element);
78 78
79 this._splitWidget.setSidebarWidget(this._searchableView); 79 this._splitWidget.setSidebarWidget(this._searchableView);
80 80
81 this._detailsWidget = new WebInspector.VBox(); 81 this._detailsWidget = new WebInspector.VBox();
82 this._detailsWidget.element.classList.add("network-details-view"); 82 this._detailsWidget.element.classList.add("network-details-view");
83 this._splitWidget.setMainWidget(this._detailsWidget); 83 this._splitWidget.setMainWidget(this._detailsWidget);
84 84
85 this._closeButtonElement = createElementWithClass("div", "network-close-butt on", "dt-close-button"); 85 this._closeButtonElement = createElement("div", "dt-close-button");
86 this._closeButtonElement.addEventListener("click", this._showRequest.bind(th is, null), false); 86 this._closeButtonElement.addEventListener("click", this._showRequest.bind(th is, null), false);
87 87
88 this._networkLogShowOverviewSetting.addChangeListener(this._toggleShowOvervi ew, this); 88 this._networkLogShowOverviewSetting.addChangeListener(this._toggleShowOvervi ew, this);
89 this._networkLogLargeRowsSetting.addChangeListener(this._toggleLargerRequest s, this); 89 this._networkLogLargeRowsSetting.addChangeListener(this._toggleLargerRequest s, this);
90 this._networkRecordFilmStripSetting.addChangeListener(this._toggleRecordFilm Strip, this); 90 this._networkRecordFilmStripSetting.addChangeListener(this._toggleRecordFilm Strip, this);
91 91
92 this._toggleRecord(true); 92 this._toggleRecord(true);
93 this._toggleShowOverview(); 93 this._toggleShowOverview();
94 this._toggleLargerRequests(); 94 this._toggleLargerRequests();
95 this._toggleRecordFilmStrip(); 95 this._toggleRecordFilmStrip();
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 */ 412 */
413 _showRequest: function(request) 413 _showRequest: function(request)
414 { 414 {
415 if (this._networkItemView) { 415 if (this._networkItemView) {
416 this._networkItemView.detach(); 416 this._networkItemView.detach();
417 this._networkItemView = null; 417 this._networkItemView = null;
418 } 418 }
419 419
420 if (request) { 420 if (request) {
421 this._networkItemView = new WebInspector.NetworkItemView(request, th is._networkLogView.timeCalculator()); 421 this._networkItemView = new WebInspector.NetworkItemView(request, th is._networkLogView.timeCalculator());
422 this._networkItemView.insertBeforeTabStrip(this._closeButtonElement) ; 422 this._networkItemView.leftToolbar().appendToolbarItem(new WebInspect or.ToolbarItem(this._closeButtonElement));
423 this._networkItemView.show(this._detailsWidget.element); 423 this._networkItemView.show(this._detailsWidget.element);
424 this._splitWidget.showBoth(); 424 this._splitWidget.showBoth();
425 } else { 425 } else {
426 this._splitWidget.hideMain(); 426 this._splitWidget.hideMain();
427 this._networkLogView.clearSelection(); 427 this._networkLogView.clearSelection();
428 } 428 }
429 this._updateUI(); 429 this._updateUI();
430 }, 430 },
431 431
432 _updateUI: function() 432 _updateUI: function()
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
769 * @return {boolean} 769 * @return {boolean}
770 */ 770 */
771 handleAction: function(context, actionId) 771 handleAction: function(context, actionId)
772 { 772 {
773 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel); 773 var panel = WebInspector.context.flavor(WebInspector.NetworkPanel);
774 console.assert(panel && panel instanceof WebInspector.NetworkPanel); 774 console.assert(panel && panel instanceof WebInspector.NetworkPanel);
775 panel._toggleRecording(); 775 panel._toggleRecording();
776 return true; 776 return true;
777 } 777 }
778 } 778 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698