Fix memory leak reported by clang static analyzer.

Fix memory leak reported by clang static analyzer.

The SelectorPickerViewController instance create and assigned to the
selectorPickerViewController property was over retained, fix this by
invoking -autorelease.

BUG=648210
Committed: https://crrev.com/36d9ae1bdcefef46c37da0eb0194a0becba417a9
Cr-Commit-Position: refs/heads/master@{#420017}

[sdefresne, 2016-09-20 14:49:25]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 14:49:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 14:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 14:57:45]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-09-20 15:06:23]

sdefresne@chromium.org changed reviewers:
+ jyquinn@chromium.org

[sdefresne, 2016-09-20 15:06:24]

Please take a look and send to CQ if LGTY.

[Jackie Quinn, 2016-09-20 20:07:15]

On 2016/09/20 15:06:24, sdefresne wrote:
> Please take a look and send to CQ if LGTY.

lgtm, but isn't that taken care of by the property releaser? Have I been doing
this wrong the whole time? 😳

[noyau (Ping after 24h), 2016-09-21 09:07:43]

On 2016/09/20 20:07:15, Jackie Quinn wrote:
> On 2016/09/20 15:06:24, sdefresne wrote:
> > Please take a look and send to CQ if LGTY.
> 
> lgtm, but isn't that taken care of by the property releaser? Have I been doing
> this wrong the whole time? 😳

_foo = [[Foo alloc] init] would have been correct. But the code here is self.foo
= [[Foo alloc] init], creating a double retain, one from the allocation and one
from the setter.

[sdefresne, 2016-09-21 09:16:28]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-09-21 09:16:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 09:21:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-21 09:23:33]

Description was changed from

==========
Fix memory leak reported by clang static analyzer.

The SelectorPickerViewController instance create and assigned to the
selectorPickerViewController property was over retained, fix this by
invoking -autorelease.

BUG=648210
==========

to

==========
Fix memory leak reported by clang static analyzer.

The SelectorPickerViewController instance create and assigned to the
selectorPickerViewController property was over retained, fix this by
invoking -autorelease.

BUG=648210

Committed: https://crrev.com/36d9ae1bdcefef46c37da0eb0194a0becba417a9
Cr-Commit-Position: refs/heads/master@{#420017}
==========

[commit-bot: I haz the power, 2016-09-21 09:23:33]

Patchset 1 (id:??) landed as
https://crrev.com/36d9ae1bdcefef46c37da0eb0194a0becba417a9
Cr-Commit-Position: refs/heads/master@{#420017}