Don't use the same no-op filter for all url() inputs and outputs, or caching gets confused.

Don't use the same no-op filter for all url() inputs and outputs, or caching gets confused. NULL will do.

Covered by css3/filters/effect-reference-ordering-hw.html and others.

(This doesn't cause any test failures yet, but it will if https://codereview.chromium.org/230653005/ lands and rolls in.)

BUG=362561
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171360

[Stephen White, 2014-04-11 14:51:02]

junov@: PTAL. Thanks!

[Justin Novosad, 2014-04-11 14:57:08]

https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
File Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right):

https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119:
RefPtr<SkImageFilter> deviceFilter = transformColorSpace(0, currentColorSpace,
ColorSpaceDeviceRGB);
Literal 0 not good for readability.
Perhaps you could have: const SkImageFilter* nullFilter = 0;

[Justin Novosad, 2014-04-11 14:57:31]

On 2014/04/11 14:57:08, junov wrote:
>
https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
> File Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right):
> 
>
https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
> Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119:
> RefPtr<SkImageFilter> deviceFilter = transformColorSpace(0, currentColorSpace,
> ColorSpaceDeviceRGB);
> Literal 0 not good for readability.
> Perhaps you could have: const SkImageFilter* nullFilter = 0;

BUG number?

[Stephen White, 2014-04-11 15:12:43]

On 2014/04/11 14:57:31, junov wrote:
> On 2014/04/11 14:57:08, junov wrote:
> >
>
https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
> > File Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right):
> > 
> >
>
https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
> > Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119:
> > RefPtr<SkImageFilter> deviceFilter = transformColorSpace(0,
currentColorSpace,
> > ColorSpaceDeviceRGB);
> > Literal 0 not good for readability.
> > Perhaps you could have: const SkImageFilter* nullFilter = 0;
> 
> BUG number?

Done.

[Stephen White, 2014-04-11 15:12:48]

https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
File Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp (right):

https://codereview.chromium.org/235303002/diff/1/Source/platform/graphics/fil...
Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:119:
RefPtr<SkImageFilter> deviceFilter = transformColorSpace(0, currentColorSpace,
ColorSpaceDeviceRGB);
On 2014/04/11 14:57:08, junov wrote:
> Literal 0 not good for readability.
> Perhaps you could have: const SkImageFilter* nullFilter = 0;

Done.

[Stephen White, 2014-04-11 15:38:36]

(New patch up, BTW.)

[Justin Novosad, 2014-04-11 17:36:42]

On 2014/04/11 15:38:36, Stephen White wrote:
> (New patch up, BTW.)

lgtm

[Stephen White, 2014-04-11 17:39:14]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2014-04-11 17:39:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/senorblanco@chromium.org/235303002/40001

[commit-bot: I haz the power, 2014-04-11 17:48:45]

Change committed as 171360