Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 23530062: Revert 223324 "Wait for store flush in CookieMonster::Delete*Task" (Closed)

Created:
7 years, 3 months ago by nasko
Modified:
7 years, 3 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223324 "Wait for store flush in CookieMonster::Delete*Task" ExtensionApiTest.CookiesEvents is failing intermittently, so reverting this change. > Wait for store flush in CookieMonster::Delete*Task > > BUG=252217 > > Review URL: https://chromiumcodereview.appspot.com/18032002 TBR=philipj@opera.com,erikwright@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -156 lines) Patch
M trunk/src/net/cookies/cookie_monster.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/cookies/cookie_monster.cc View 22 chunks +140 lines, -151 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nasko
7 years, 3 months ago (2013-09-16 17:59:35 UTC) #1
nasko
Committed patchset #1 manually as r223359.
7 years, 3 months ago (2013-09-16 18:00:08 UTC) #2
philipj_slow
7 years, 3 months ago (2013-09-17 06:42:26 UTC) #3
Message was sent while issue was closed.
nasko, is this the test in
src/chrome/test/data/extensions/api_test/cookies/events/? Are there test logs
where I can see exactly in which manner it failed?

Powered by Google App Engine
This is Rietveld 408576698