Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 23530057: Merge 222950 "Adding a dialog on click of "add to homescreen" me..." (Closed)

Created:
7 years, 3 months ago by kareng
Modified:
7 years, 3 months ago
Reviewers:
Ramya
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 222950 "Adding a dialog on click of "add to homescreen" me..." > Adding a dialog on click of "add to homescreen" menu item to edit the title. > > BUG=289743 > R=dfalcantara@chromium.org, klobag@chromium.org, yfriedman@chromium.org > > Review URL: https://codereview.chromium.org/24063004 TBR=cramya@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java View 6 chunks +24 lines, -5 lines 0 comments Download
M chrome/browser/android/shortcut_helper.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kareng
7 years, 3 months ago (2013-09-13 19:56:08 UTC) #1
kareng
7 years, 3 months ago (2013-09-13 19:56:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223101.

Powered by Google App Engine
This is Rietveld 408576698