Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 23530045: Remove HandleScope default ctor. (Closed)

Created:
7 years, 3 months ago by marja
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M include/v8.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-thread-termination.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
marja
svenpanne, ptal Chrome should be migrated by now.
7 years, 3 months ago (2013-09-06 15:30:31 UTC) #1
tfarina
Marja, could you fill the BUG= line with chromium:236173?
7 years, 3 months ago (2013-09-06 15:55:19 UTC) #2
Benedikt Meurer
LGTM.
7 years, 3 months ago (2013-09-09 05:30:29 UTC) #3
marja
svenpanne: this would be ready for landing now. Does V8 have try jobs nowadays? It ...
7 years, 3 months ago (2013-09-09 08:44:08 UTC) #4
Jakob Kummerow
On 2013/09/09 08:44:08, marja wrote: > svenpanne: this would be ready for landing now. Does ...
7 years, 3 months ago (2013-09-09 09:09:52 UTC) #5
marja
... now this is ready to land for real (removed 1 more case in Chromium ...
7 years, 3 months ago (2013-09-09 15:31:50 UTC) #6
Sven Panne
LGTM (still).
7 years, 3 months ago (2013-09-10 06:10:49 UTC) #7
Sven Panne
7 years, 3 months ago (2013-09-10 06:43:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r16605 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698