Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1417)

Unified Diff: Source/core/rendering/RenderTableSection.h

Issue 23530044: Row with only spanning cells have a height of 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review comments addressed Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTableSection.h
diff --git a/Source/core/rendering/RenderTableSection.h b/Source/core/rendering/RenderTableSection.h
index 2707d74ce1dbf91b934b00f5ef67a322d7db2266..c0bd75f7149e23c355feb55a8202b21e5deaeae6 100644
--- a/Source/core/rendering/RenderTableSection.h
+++ b/Source/core/rendering/RenderTableSection.h
@@ -129,12 +129,14 @@ public:
SpanningRowsHeight()
: totalRowsHeight(0)
, spanningCellHeightIgnoringBorderSpacing(0)
+ , rowWithOnlySpanningCells(false)
{
}
Vector<int> rowHeight;
int totalRowsHeight;
int spanningCellHeightIgnoringBorderSpacing;
+ bool rowWithOnlySpanningCells;
};
const BorderValue& borderAdjoiningTableStart() const
@@ -241,6 +243,10 @@ private:
void ensureRows(unsigned);
+ unsigned rowHasOnlySpanningCells(unsigned);
+ unsigned calcRowHeightHavingOnlySpanningCells(unsigned);
+ void updateRowsHeightHavingOnlySpanningCells(RenderTableCell*, struct SpanningRowsHeight&);
+
void populateSpanningRowsHeightFromCell(RenderTableCell*, struct SpanningRowsHeight&);
void distributeExtraRowSpanHeightToPercentRows(RenderTableCell*, int, int&, Vector<int>&);
void distributeExtraRowSpanHeightToAutoRows(RenderTableCell*, int, int&, Vector<int>&);

Powered by Google App Engine
This is Rietveld 408576698