Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 23530039: Add test to exercise extreme blur sigmas (Closed)

Created:
7 years, 3 months ago by robertphillips
Modified:
7 years, 3 months ago
Reviewers:
humper, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This test would've caught the pinterest blur crash (in the .1 & .01 sigma, cpu, rect-special-case cases). Going forward I think we need to: 1) fix the underlying crash in the 9 patch code 2) update the blur code to pitch super small blurs 3) improve the non-rect-special-case cpu blur path to better match the ground truth (right now it can be 15 off)

Patch Set 1 #

Patch Set 2 : Renamed function #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -4 lines) Patch
M src/effects/SkBlurMask.cpp View 2 chunks +2 lines, -2 lines 2 comments Download
M tests/BlurTest.cpp View 1 3 chunks +240 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertphillips
https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp File src/effects/SkBlurMask.cpp (right): https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp#newcode875 src/effects/SkBlurMask.cpp:875: The 4x window still had some edge effects (when ...
7 years, 3 months ago (2013-09-05 13:30:38 UTC) #1
humper
On 2013/09/05 13:30:38, robertphillips wrote: > https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp > File src/effects/SkBlurMask.cpp (right): > > https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp#newcode875 > ...
7 years, 3 months ago (2013-09-05 14:19:01 UTC) #2
humper
On 2013/09/05 14:19:01, humper wrote: > On 2013/09/05 13:30:38, robertphillips wrote: > > https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp > ...
7 years, 3 months ago (2013-09-05 14:19:17 UTC) #3
humper
https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp File src/effects/SkBlurMask.cpp (right): https://codereview.chromium.org/23530039/diff/3001/src/effects/SkBlurMask.cpp#newcode888 src/effects/SkBlurMask.cpp:888: float gaussian = expf(-x*x / (2*variance)); WHOOPS, nice catch.
7 years, 3 months ago (2013-09-05 14:19:23 UTC) #4
bsalomon
I defer to humper@
7 years, 3 months ago (2013-09-05 14:23:59 UTC) #5
robertphillips
7 years, 3 months ago (2013-09-05 16:39:21 UTC) #6
Message was sent while issue was closed.
committed as r11099

Powered by Google App Engine
This is Rietveld 408576698