Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 2353003004: Move ViewHostMsg_CreateWindow to mojom (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index 6d4e908768ef7c67faf0459c529671e9dbc690ce..68c6f3168614b335a27ffa43035f37e579275a07 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -48,6 +48,7 @@
#include "content/common/frame_messages.h"
#include "content/common/input_messages.h"
#include "content/common/inter_process_time_ticks_converter.h"
+#include "content/common/render_message_filter.mojom.h"
#include "content/common/site_isolation_policy.h"
#include "content/common/speech_recognition_messages.h"
#include "content/common/swapped_out_messages.h"
@@ -886,15 +887,15 @@ void RenderViewHostImpl::CreateNewWindow(
int32_t route_id,
int32_t main_frame_route_id,
int32_t main_frame_widget_route_id,
- const ViewHostMsg_CreateWindow_Params& params,
+ const mojom::CreateWindowParams& params,
SessionStorageNamespace* session_storage_namespace) {
- ViewHostMsg_CreateWindow_Params validated_params(params);
- GetProcess()->FilterURL(false, &validated_params.target_url);
- GetProcess()->FilterURL(false, &validated_params.opener_url);
- GetProcess()->FilterURL(true, &validated_params.opener_security_origin);
+ mojom::CreateWindowParamsPtr validated_params(params.Clone());
+ GetProcess()->FilterURL(false, &validated_params->target_url);
+ GetProcess()->FilterURL(false, &validated_params->opener_url);
+ GetProcess()->FilterURL(true, &validated_params->opener_security_origin);
delegate_->CreateNewWindow(GetSiteInstance(), route_id, main_frame_route_id,
- main_frame_widget_route_id, validated_params,
+ main_frame_widget_route_id, *validated_params,
session_storage_namespace);
}
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698