Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest_manager.cc

Issue 23530029: Support webview tag when the container extension is embedded in a webUI (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: guest site instance fixed Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest_manager.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest_manager.cc b/content/browser/browser_plugin/browser_plugin_guest_manager.cc
index 75de20313331abe2238a35edccd800ee42bfccb3..de8f8dac03ac61857e6d3dd49272b57e14b23102 100644
--- a/content/browser/browser_plugin/browser_plugin_guest_manager.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest_manager.cc
@@ -70,7 +70,7 @@ BrowserPluginGuest* BrowserPluginGuestManager::CreateGuest(
guest_site_instance =
embedder_site_instance->GetRelatedSiteInstance(GURL(params.src));
} else {
- const std::string& host = embedder_site_instance->GetSiteURL().host();
+ const std::string& host = GURL(params.embedder_frame_url).host();
Fady Samuel 2013/09/12 21:54:38 Wow, this is a bit scary. You should only be doing
guohui 2013/09/12 22:06:08 We got the frame URL you mean the frame URL we go
Fady Samuel 2013/09/12 22:11:21 The embedder's site instance is a URL generated by
guohui 2013/09/12 22:36:12 that makes sense, thanks! fixed as suggested.
std::string url_encoded_partition = net::EscapeQueryParamValue(
params.storage_partition_id, false);
« no previous file with comments | « content/browser/browser_plugin/browser_plugin_embedder.cc ('k') | content/browser/web_contents/render_view_host_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698