Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 23530026: CSS Blending: Mix-blend-mode shouldn't force the creation of a composited layer. (Closed)

Created:
7 years, 3 months ago by mitica
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

CSS Blending: Mix-blend-mode shouldn't force the creation of a composited layer. This changeset removes the chromium side of notifying when an accelerated layer is created due to an element having mix-blend-mode set from CSS. This change is required before actually remove this in Blink. BUG=285153 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223284

Patch Set 1 #

Patch Set 2 : Reworked patch, the previous version created compiling errors. #

Patch Set 3 : Completely remove BlendingCompositingReason #

Patch Set 4 : Completely remove blending compositing flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M cc/layers/compositing_reasons.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_compositing_reasons.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mitica
Hi James, can you please review this changeset? Thanks!
7 years, 3 months ago (2013-09-04 13:33:49 UTC) #1
mitica
Reworked patch, the previous version created compiling errors.
7 years, 3 months ago (2013-09-10 12:19:08 UTC) #2
mitica
Can you please have a look at this? Thanks!
7 years, 3 months ago (2013-09-12 16:24:59 UTC) #3
shawnsingh
On 2013/09/12 16:24:59, mitica wrote: > Can you please have a look at this? Thanks! ...
7 years, 3 months ago (2013-09-13 08:08:54 UTC) #4
mitica
On 2013/09/13 08:08:54, shawnsingh wrote: > On 2013/09/12 16:24:59, mitica wrote: > > Can you ...
7 years, 3 months ago (2013-09-13 08:11:29 UTC) #5
enne (OOO)
lgtm
7 years, 3 months ago (2013-09-13 15:26:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/23530026/9001
7 years, 3 months ago (2013-09-14 15:55:16 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=79049
7 years, 3 months ago (2013-09-15 01:06:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mitica@adobe.com/23530026/9001
7 years, 3 months ago (2013-09-15 07:04:41 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-15 15:13:32 UTC) #10
Message was sent while issue was closed.
Change committed as 223284

Powered by Google App Engine
This is Rietveld 408576698