Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 23530023: spellcheck-disable-enable.html fails when asynchronous spellchecking is on (Closed)

Created:
7 years, 3 months ago by grzegorz
Modified:
7 years, 3 months ago
Reviewers:
Hajime Morrita, tony
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

spellcheck-disable-enable.html fails when asynchronous spellchecking is on This test doesn't need asynchronous spell checking. Its purpose is to verify how spelling markers behave when spell checker feature is being toggled. Restore synchronous spell checking which was disabled at r157059 and remove unnecessary and misleading code. BUG=282426 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/editing/spelling/spellcheck-disable-enable.html View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
grzegorz
7 years, 3 months ago (2013-09-04 13:06:27 UTC) #1
tony
LGTM
7 years, 3 months ago (2013-09-04 17:16:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/g.czajkowski@samsung.com/23530023/1
7 years, 3 months ago (2013-09-04 17:17:08 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 18:49:59 UTC) #4
Message was sent while issue was closed.
Change committed as 157229

Powered by Google App Engine
This is Rietveld 408576698