[cleanup] Remove LauncherItemChanged() from LauncherItemController

chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 
 #include <vector>
 
 #include "ash/ash_switches.h"
 #include "ash/launcher/launcher.h"
@@ skipping 977 matching lines @@
 
 void ChromeLauncherController::LauncherItemMoved(int start_index,
                                                  int target_index) {
   ash::LauncherID id = model_->items()[target_index].id;
   if (HasItemController(id) && IsPinned(id))
     PersistPinnedState();
 }
 
 void ChromeLauncherController::LauncherItemChanged(
     int index,
     const ash::LauncherItem& old_item) {

[Mr4D (OOO till 08-26), 2013/09/04 03:47:02]

You removed the LauncherItemChanged everywhere. Is this empty function still
required?

[simonhong_, 2013/09/04 04:12:04]

This is not needed in CLC.
But I can't remove because this is pure abstract method.

[Mr4D (OOO till 08-26), 2013/09/04 14:43:47]

Right. But ... I was looking quickly over the 16 references to
LauncherItemChanged and I might be wrong, but it looks like that this can be
removed now altogether since this was the only recipient for these calls.

[simonhong_, 2013/09/04 16:41:23]

But.. LauncherItemMoved() is still needed by CLC.
Do I miss something from your comment?

-  ash::LauncherID id = model_->items()[index].id;
-  DCHECK(HasItemController(id));
-  id_to_item_controller_map_[id]->LauncherItemChanged(index, old_item);
 }
 
 void ChromeLauncherController::LauncherStatusChanged() {
 }
 
 void ChromeLauncherController::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   switch (type) {
@@ skipping 644 matching lines @@
   // TODO(simon.hong81): Register LauncherItemDelegate when LauncherItemDelegate
   // is created.
   ash::LauncherItemDelegateManager* manager =
       ash::Shell::GetInstance()->launcher_item_delegate_manager();
   manager->RegisterLauncherItemDelegate(ash::TYPE_APP_PANEL, this);
   manager->RegisterLauncherItemDelegate(ash::TYPE_APP_SHORTCUT, this);
   manager->RegisterLauncherItemDelegate(ash::TYPE_BROWSER_SHORTCUT, this);
   manager->RegisterLauncherItemDelegate(ash::TYPE_PLATFORM_APP, this);
   manager->RegisterLauncherItemDelegate(ash::TYPE_WINDOWED_APP, this);
 }