cc: Block commit on activate by setting a flag on LayerTreeHost.

cc/layers/tiled_layer.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/tiled_layer.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/auto_reset.h"
@@ skipping 217 matching lines @@
        iter != invalid_tiles.end();
        ++iter)
     tiler_->TakeTile((*iter)->i(), (*iter)->j());
 
   // TiledLayer must push properties every frame, since viewport state and
   // occlusion from anywhere in the tree can change what the layer decides to
   // push to the impl tree.
   needs_push_properties_ = true;
 }
 
-bool TiledLayer::BlocksPendingCommit() const { return true; }

[enne (OOO), 2013/08/29 20:01:33]

I don't think this is safe to just remove.

[enne (OOO), 2013/08/29 20:03:22]

Or, it seems unlikely that anybody would stick a TiledLayer into an impl-side
painting tree, but if they did TiledLayer really doesn't support that.  So,
there either needs to be some safety here via blocking commits or a CHECK or
something?

[danakj, 2013/08/29 20:13:52]

Unit tests do it, but they all pass. So I was like *shrug*. But okay I'll make
this layer set the bit in Update().

[enne (OOO), 2013/08/29 20:19:10]

...

I think partial updates would be very wrong with impl-side painting.  Mostly,
it's that this path isn't tested very well, so I'd prefer to avoid it entirely.

-
 PrioritizedResourceManager* TiledLayer::ResourceManager() {
   if (!layer_tree_host())
     return NULL;
   return layer_tree_host()->contents_texture_manager();
 }
 
 const PrioritizedResource* TiledLayer::ResourceAtForTesting(int i,
                                                             int j) const {
   UpdatableTile* tile = TileAt(i, j);
   if (!tile)
@@ skipping 642 matching lines @@
   gfx::Rect prepaint_rect = visible_content_rect();
   prepaint_rect.Inset(-tiler_->tile_size().width() * kPrepaintColumns,
                       -tiler_->tile_size().height() * kPrepaintRows);
   gfx::Rect content_rect(content_bounds());
   prepaint_rect.Intersect(content_rect);
 
   return prepaint_rect;
 }
 
 }  // namespace cc