Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2352983002: [chrome.displaySource] Fix service impl constructors. (Closed)

Created:
4 years, 3 months ago by e_hakkinen
Modified:
4 years, 3 months ago
Reviewers:
shalamov, Mikhail
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chrome.displaySource] Fix service impl constructors. This CL completes changes constructor declarations by changing definitions accordingly. This also avoid external calls to private constructors. BUG=242107 Committed: https://crrev.com/ed168b3b8f34db55dc91d279e779e428e506a856 Cr-Commit-Position: refs/heads/master@{#419725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
e_hakkinen
PTAL.
4 years, 3 months ago (2016-09-20 10:10:43 UTC) #2
Mikhail
lgtm
4 years, 3 months ago (2016-09-20 11:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352983002/1
4 years, 3 months ago (2016-09-20 11:48:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 12:26:24 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:29:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed168b3b8f34db55dc91d279e779e428e506a856
Cr-Commit-Position: refs/heads/master@{#419725}

Powered by Google App Engine
This is Rietveld 408576698