mustash: Restrict //ash/DEPS to services available in ash process

mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit

Committed: https://crrev.com/2ffdb659830b0b1a5875f2357c2f8c5b8beacc6a
Cr-Commit-Position: refs/heads/master@{#419824}

[James Cook, 2016-09-20 17:30:51]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-09-20 17:31:03]

Description was changed from

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=ash_unittests
==========

to

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit
==========

[commit-bot: I haz the power, 2016-09-20 17:31:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 17:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 17:41:07]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-09-20 17:52:48]

jamescook@chromium.org changed reviewers:
+ stevenjb@chromium.org

[James Cook, 2016-09-20 17:52:48]

stevenjb, please take a look.

[stevenjb, 2016-09-20 18:04:42]

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS
File ash/DEPS (right):

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS#newcode40
ash/DEPS:40: "+chromeos/system",
Does it make sense to move some of these down to ash/system/chromeos ?

[James Cook, 2016-09-20 18:14:43]

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS
File ash/DEPS (right):

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS#newcode40
ash/DEPS:40: "+chromeos/system",
On 2016/09/20 18:04:42, stevenjb wrote:
> Does it make sense to move some of these down to ash/system/chromeos ?

I prefer to keep them here. Note that there are both //ash/system/chromeos and
//ash/common/system/chromeos directories (for classic ash vs. mustash code). The
former probably won't go away entirely until we turn off classic ash.

Also, usage isn't that concentrated in the system directories:

git grep "include \"chromeos" ash

I think it's easier to reason about the deps if they all live here.

[stevenjb, 2016-09-20 18:20:31]

lgtm

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS
File ash/DEPS (right):

https://codereview.chromium.org/2352973003/diff/40001/ash/DEPS#newcode40
ash/DEPS:40: "+chromeos/system",
On 2016/09/20 18:14:42, James Cook wrote:
> On 2016/09/20 18:04:42, stevenjb wrote:
> > Does it make sense to move some of these down to ash/system/chromeos ?
> 
> I prefer to keep them here. Note that there are both //ash/system/chromeos and
> //ash/common/system/chromeos directories (for classic ash vs. mustash code).
The
> former probably won't go away entirely until we turn off classic ash.
> 
> Also, usage isn't that concentrated in the system directories:
> 
> git grep "include \"chromeos" ash
> 
> I think it's easier to reason about the deps if they all live here.

OK

[James Cook, 2016-09-20 18:23:21]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-09-20 18:23:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 18:36:25]

Description was changed from

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit
==========

to

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit
==========

[commit-bot: I haz the power, 2016-09-20 18:36:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-20 18:38:17]

Description was changed from

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit
==========

to

==========
mustash: Restrict //ash/DEPS to services available in ash process

Only a subset of D-Bus clients and services are availabe in the mustash ash
process. Use DEPS to restrict access to the ones that are allowed.

BUG=629707
TEST=presubmit

Committed: https://crrev.com/2ffdb659830b0b1a5875f2357c2f8c5b8beacc6a
Cr-Commit-Position: refs/heads/master@{#419824}
==========

[commit-bot: I haz the power, 2016-09-20 18:38:18]

Patchset 3 (id:??) landed as
https://crrev.com/2ffdb659830b0b1a5875f2357c2f8c5b8beacc6a
Cr-Commit-Position: refs/heads/master@{#419824}