content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc - Issue 2352963002: cc: Make most of cc::OutputSurface abstract.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

Issue 2352963002: cc: Make most of cc::OutputSurface abstract. (Closed)

Patch Set: outputsurface-cleanup: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/output/output_surface.cc ('K') | « content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h ('k') | content/browser/compositor/offscreen_browser_compositor_output_surface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

diff --git a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

index a46fc17d5df9121b710be5876bb3cf0b54bf9b8f..6f759206916d72791bd01ca8292607ff5ca75d0d 100644

--- a/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

+++ b/content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc

@@ -75,12 +75,6 @@ void GpuSurfacelessBrowserCompositorOutputSurface::SwapBuffers(

GpuBrowserCompositorOutputSurface::SwapBuffers(std::move(frame));

}

-void GpuSurfacelessBrowserCompositorOutputSurface::OnSwapBuffersComplete() {

- DCHECK(buffer_queue_);

- buffer_queue_->PageFlipComplete();

- GpuBrowserCompositorOutputSurface::OnSwapBuffersComplete();

void GpuSurfacelessBrowserCompositorOutputSurface::BindFramebuffer() {

DCHECK(buffer_queue_);

buffer_queue_->BindFramebuffer();

@@ -114,6 +108,7 @@ void GpuSurfacelessBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted(

buffer_queue_->RecreateBuffers();

force_swap = true;

}

+ buffer_queue_->PageFlipComplete();

boliu 2016/09/26 17:14:50 copy the DCHECK from old code too?

danakj 2016/09/26 18:54:44 I'm not sure what value it is TBH. We set this mem

GpuBrowserCompositorOutputSurface::OnGpuSwapBuffersCompleted(

latency_info, result, params_mac);

if (force_swap)