chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java - Issue 2352943003: Remove the context argument from all WebappRegistry/WebappDataStorage methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

Issue 2352943003: Remove the context argument from all WebappRegistry/WebappDataStorage methods. (Closed)

Patch Set: Address comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenIconTest.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebappDataStorageTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

index 6951ff945997a472fd3aa629acf7ea4bb453f43c..1d2271e8ecf5ba03fb46c440cdb51815c68b381c 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappSplashScreenTest.java

@@ -237,7 +237,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {

R.dimen.webapp_splash_image_size_threshold);

int bitmapSize = thresholdSize + 1;

Bitmap splashBitmap = Bitmap.createBitmap(bitmapSize, bitmapSize, Bitmap.Config.ARGB_8888);

- WebappDataStorage.open(context, WEBAPP_ID).updateSplashScreenImage(splashBitmap);

+ WebappDataStorage.open(WEBAPP_ID).updateSplashScreenImage(splashBitmap);

startWebappActivity(createIntent());

ViewGroup splashScreen = waitUntilSplashScreenAppears();

@@ -265,7 +265,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {

int bitmapSize = context.getResources().getDimensionPixelSize(

R.dimen.webapp_splash_image_size_minimum);

Bitmap splashBitmap = Bitmap.createBitmap(bitmapSize, bitmapSize, Bitmap.Config.ARGB_8888);

- WebappDataStorage.open(context, WEBAPP_ID).updateSplashScreenImage(splashBitmap);

+ WebappDataStorage.open(WEBAPP_ID).updateSplashScreenImage(splashBitmap);

startWebappActivity(createIntent());

ViewGroup splashScreen = waitUntilSplashScreenAppears();

@@ -292,7 +292,7 @@ public class WebappSplashScreenTest extends WebappActivityTestBase {

int bitmapSize = context.getResources().getDimensionPixelSize(

R.dimen.webapp_splash_image_size_minimum) - 1;

Bitmap splashBitmap = Bitmap.createBitmap(bitmapSize, bitmapSize, Bitmap.Config.ARGB_8888);

- WebappDataStorage.open(context, WEBAPP_ID).updateSplashScreenImage(splashBitmap);

+ WebappDataStorage.open(WEBAPP_ID).updateSplashScreenImage(splashBitmap);

Intent intent = createIntent();

intent.putExtra(ShortcutHelper.EXTRA_IS_ICON_GENERATED, true);