Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java

Issue 2352943003: Remove the context argument from all WebappRegistry/WebappDataStorage methods. (Closed)
Patch Set: Remove more getApplicationContexts Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
index d42f7b280ece41d8dd50d1e385f40a713f090f45..f65ee2a29599f7ed34e5d8355ba1ca3106e1d3e1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDataStorage.java
@@ -106,8 +106,7 @@ public class WebappDataStorage {
new AsyncTask<Void, Void, Long>() {
@Override
protected final Long doInBackground(Void... nothing) {
- long lastUsed = new WebappDataStorage(context.getApplicationContext(), webappId)
- .getLastUsedTime();
+ long lastUsed = new WebappDataStorage(context, webappId).getLastUsedTime();
Peter Wen 2016/09/21 14:58:41 No need to pass in context to the constructor.
dominickn 2016/09/22 03:47:00 Done.
assert lastUsed != LAST_USED_INVALID;
return lastUsed;
}
@@ -133,7 +132,7 @@ public class WebappDataStorage {
new AsyncTask<Void, Void, String>() {
@Override
protected final String doInBackground(Void... nothing) {
- return new WebappDataStorage(context.getApplicationContext(), webappId).getScope();
+ return new WebappDataStorage(context, webappId).getScope();
}
@Override
@@ -156,7 +155,7 @@ public class WebappDataStorage {
new AsyncTask<Void, Void, String>() {
@Override
protected final String doInBackground(Void... nothing) {
- return new WebappDataStorage(context.getApplicationContext(), webappId).getUrl();
+ return new WebappDataStorage(context, webappId).getUrl();
}
@Override
@@ -217,7 +216,7 @@ public class WebappDataStorage {
}
private static SharedPreferences openSharedPreferences(Context context, String webappId) {
Peter Wen 2016/09/21 14:58:41 No need for context param.
dominickn 2016/09/22 03:47:00 Done.
- return context.getApplicationContext().getSharedPreferences(
+ return context.getSharedPreferences(
Peter Wen 2016/09/21 14:58:41 ContextUtils.getApplicationContext().getSharedPref
dominickn 2016/09/22 03:47:00 Done.
SHARED_PREFS_FILE_PREFIX + webappId, Context.MODE_PRIVATE);
}

Powered by Google App Engine
This is Rietveld 408576698