Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: test/mjsunit/harmony/debug-async-function-async-task-event.js

Issue 2352933002: Reland of Fix async/await memory leak (Closed)
Patch Set: Note about tests; remove bad tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/debug-async-function-async-task-event.js
diff --git a/test/mjsunit/harmony/debug-async-function-async-task-event.js b/test/mjsunit/harmony/debug-async-function-async-task-event.js
index 249f02fc8f6841a9e8624223443ae6840741bf29..5e01938f361b6ef7ecf123cb2aecd5901cf71da0 100644
--- a/test/mjsunit/harmony/debug-async-function-async-task-event.js
+++ b/test/mjsunit/harmony/debug-async-function-async-task-event.js
@@ -4,25 +4,26 @@
// Flags: --harmony-async-await --expose-debug-as debug --allow-natives-syntax
+// The test observes the callbacks that async/await makes to the inspector
+// to make accurate stack traces. The limited number of events is an
+// indirect indication that we are not doing extra Promise processing that
+// could be associated with memory leaks (v8:5380).
+// TODO(littledan): Write a test that demonstrates that the memory leak in
+// the exception case is fixed.
+
Debug = debug.Debug;
var base_id = -1;
var exception = null;
var expected = [
- "enqueue #1",
- "willHandle #1",
- "then #1",
- "enqueue #2",
- "enqueue #3",
- "didHandle #1",
- "willHandle #2",
- "then #2",
- "didHandle #2",
- "willHandle #3",
- "enqueue #4",
- "didHandle #3",
- "willHandle #4",
- "didHandle #4",
+ 'enqueue #1',
+ 'willHandle #1',
+ 'then #1',
+ 'enqueue #2',
+ 'didHandle #1',
+ 'willHandle #2',
+ 'then #2',
+ 'didHandle #2',
];
function assertLog(msg) {
« no previous file with comments | « src/parsing/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698