Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2352913003: Use indexing for type variable access when the receiver type constrains the substitution(s) (Closed)

Created:
4 years, 3 months ago by sra1
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use indexing for type variable access when the receiver type constrains the substitution(s) Often we are accessing Iterable.E from a precisely known class. BUG= R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/5cafe425771170dbbb1038e32c4f09f298574505

Patch Set 1 #

Patch Set 2 : rebase and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -7 lines) Patch
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 chunks +20 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 3 months ago (2016-09-20 22:48:17 UTC) #2
Johnni Winther
lgtm
4 years, 3 months ago (2016-09-21 09:24:10 UTC) #3
sra1
4 years, 3 months ago (2016-09-22 18:32:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5cafe425771170dbbb1038e32c4f09f298574505 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698