Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2352913002: Remove VIDEO_HOLE from chromecast (Closed)

Created:
4 years, 3 months ago by boliu
Modified:
4 years, 3 months ago
Reviewers:
lcwu1, halliwell, AndyWu
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove VIDEO_HOLE from chromecast Mostly just removing components/external_video_surface dependency. Committed: https://crrev.com/58ec2022e9cf83f5c498dbf7a5f545ebf81c2235 Cr-Commit-Position: refs/heads/master@{#419793}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M chromecast/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/android/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/android/cast_jni_registrar.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromecast/browser/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M chromecast/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
boliu
ptal
4 years, 3 months ago (2016-09-19 23:00:25 UTC) #2
lcwu1
4 years, 3 months ago (2016-09-19 23:03:45 UTC) #4
boliu
ping? anyone want to actually approve here?
4 years, 3 months ago (2016-09-20 15:00:26 UTC) #5
halliwell
On 2016/09/20 15:00:26, boliu wrote: > ping? anyone want to actually approve here? lgtm :)
4 years, 3 months ago (2016-09-20 15:18:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352913002/1
4 years, 3 months ago (2016-09-20 15:18:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 16:57:43 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 17:00:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58ec2022e9cf83f5c498dbf7a5f545ebf81c2235
Cr-Commit-Position: refs/heads/master@{#419793}

Powered by Google App Engine
This is Rietveld 408576698