DescriptionRevert of Always use valid enum values in gfx::ColorSpace (patchset #3 id:40001 of https://codereview.chromium.org/2338213009/ )
Reason for revert:
broke build:
https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/17323
DCHECK failure:
[29864:20227:0919/143752:FATAL:gfx_param_traits_macros.h(19)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)).
0 Chromium Framework 0x0000000107a6caf3 _ZN4base5debug10StackTraceC1Ev + 19
1 Chromium Framework 0x0000000107a8eb17 _ZN7logging10LogMessageD2Ev + 71
2 Chromium Framework 0x00000001090ac690 _ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 96
3 Chromium Framework 0x000000010909096e _ZN3IPC11ParamTraitsIN2cc20TransferableResourceEE5WriteEPN4base6PickleERKS2_ + 270
Original issue's description:
> Always use valid enum values in gfx::ColorSpace
>
> As a bonus, we get warnings if you add a new enum value without
> updating gfx::ColorTransform.
>
> Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610
> Cr-Commit-Position: refs/heads/master@{#419552}
TBR=sandersd@chromium.org,ccameron@chromium.org,hubbe@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/7ee7d41f020f38879af66e568ac64b47fc0e3550
Cr-Commit-Position: refs/heads/master@{#419598}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|