Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 2352903002: Revert of Always use valid enum values in gfx::ColorSpace (Closed)

Created:
4 years, 3 months ago by Dmitry Titov
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always use valid enum values in gfx::ColorSpace (patchset #3 id:40001 of https://codereview.chromium.org/2338213009/ ) Reason for revert: broke build: https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Retina%20Release%20%28AMD%29/builds/17323 DCHECK failure: [29864:20227:0919/143752:FATAL:gfx_param_traits_macros.h(19)] Check failed: (static_cast<int>(value) >= static_cast<int>(0) && static_cast<int>(value) <= static_cast<int>(gfx::ColorSpace::PrimaryID::LAST)). 0 Chromium Framework 0x0000000107a6caf3 _ZN4base5debug10StackTraceC1Ev + 19 1 Chromium Framework 0x0000000107a8eb17 _ZN7logging10LogMessageD2Ev + 71 2 Chromium Framework 0x00000001090ac690 _ZN3IPC11ParamTraitsIN3gfx10ColorSpaceEE5WriteEPN4base6PickleERKS2_ + 96 3 Chromium Framework 0x000000010909096e _ZN3IPC11ParamTraitsIN2cc20TransferableResourceEE5WriteEPN4base6PickleERKS2_ + 270 Original issue's description: > Always use valid enum values in gfx::ColorSpace > > As a bonus, we get warnings if you add a new enum value without > updating gfx::ColorTransform. > > Committed: https://crrev.com/a54ef7e4e7e234b2bb95f2000b72da718cbbc610 > Cr-Commit-Position: refs/heads/master@{#419552} TBR=sandersd@chromium.org,ccameron@chromium.org,hubbe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7ee7d41f020f38879af66e568ac64b47fc0e3550 Cr-Commit-Position: refs/heads/master@{#419598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -142 lines) Patch
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M ui/gfx/color_space.h View 4 chunks +6 lines, -19 lines 0 comments Download
M ui/gfx/color_space.cc View 2 chunks +0 lines, -36 lines 0 comments Download
M ui/gfx/color_transform.cc View 16 chunks +46 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dmitry Titov
Created Revert of Always use valid enum values in gfx::ColorSpace
4 years, 3 months ago (2016-09-19 22:48:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352903002/1
4 years, 3 months ago (2016-09-19 22:49:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 22:50:00 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 22:52:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ee7d41f020f38879af66e568ac64b47fc0e3550
Cr-Commit-Position: refs/heads/master@{#419598}

Powered by Google App Engine
This is Rietveld 408576698