Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 23529005: Introduce toSVGFEDiffuseLightingElement(), and use it (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce toSVGFEDiffuseLightingElement(), and use it As a step to clean-up static_cast<SVGXXX>, toSVGFEDiffuseLightingElement() is added to clean-up static_cast<SVGFEDiffuseLightingElement*>. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/svg/SVGFEDiffuseLightingElement.h View 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 3 months ago (2013-08-30 05:59:27 UTC) #1
tkent
lgtm You may add multiple toSVGFE*Element in single CL.
7 years, 3 months ago (2013-08-30 06:02:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23529005/1
7 years, 3 months ago (2013-08-30 06:02:11 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 08:01:20 UTC) #4
Message was sent while issue was closed.
Change committed as 156968

Powered by Google App Engine
This is Rietveld 408576698