Disallow redundant Bind calls.

base/bind_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/test/gtest_util.h"
 #include "build/build_config.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
+using ::testing::_;
 using ::testing::Mock;
 using ::testing::Return;
 using ::testing::StrictMock;
 
 namespace base {
 namespace {
 
 class IncompleteType;
 
 class NoRef {
  public:
   NoRef() {}
 
   MOCK_METHOD0(VoidMethod0, void());
   MOCK_CONST_METHOD0(VoidConstMethod0, void());
 
   MOCK_METHOD0(IntMethod0, int());
   MOCK_CONST_METHOD0(IntConstMethod0, int());
 
+  MOCK_METHOD1(VoidMethodWithIntArg, void(int));
+
  private:
   // Particularly important in this test to ensure no copies are made.
   DISALLOW_COPY_AND_ASSIGN(NoRef);
 };
 
 class HasRef : public NoRef {
  public:
   HasRef() {}
 
   MOCK_CONST_METHOD0(AddRef, void());
@@ skipping 978 matching lines @@
   int x = 1;
   base::Callback<void(int)> cb =
       Bind([](int* x, int i) { *x *= i; }, Unretained(&x));
   cb.Run(6);
   EXPECT_EQ(6, x);
   cb.Run(7);
   EXPECT_EQ(42, x);
 }
 
 TEST_F(BindTest, Cancellation) {
-  EXPECT_CALL(no_ref_, VoidMethod0()).Times(2);
+  EXPECT_CALL(no_ref_, VoidMethodWithIntArg(_)).Times(2);
 
   WeakPtrFactory<NoRef> weak_factory(&no_ref_);
-  Closure cb = Bind(&NoRef::VoidMethod0, weak_factory.GetWeakPtr());
-  Closure cb2 = Bind(cb);
+  base::Callback<void(int)> cb =
+      Bind(&NoRef::VoidMethodWithIntArg, weak_factory.GetWeakPtr());
+  Closure cb2 = Bind(cb, 8);
 
   EXPECT_FALSE(cb.IsCancelled());
   EXPECT_FALSE(cb2.IsCancelled());
 
-  cb.Run();
+  cb.Run(6);
   cb2.Run();
 
   weak_factory.InvalidateWeakPtrs();
 
   EXPECT_TRUE(cb.IsCancelled());
   EXPECT_TRUE(cb2.IsCancelled());
 
-  cb.Run();
+  cb.Run(6);
   cb2.Run();
 }
 
 TEST_F(BindTest, OnceCallback) {
   using internal::OnceClosure;
   using internal::RepeatingClosure;
   using internal::BindOnce;
   using internal::BindRepeating;
   using internal::OnceCallback;
 
@@ skipping 109 matching lines @@
 
 // Test null callbacks cause a DCHECK.
 TEST(BindDeathTest, NullCallback) {
   base::Callback<void(int)> null_cb;
   ASSERT_TRUE(null_cb.is_null());
   EXPECT_DCHECK_DEATH(base::Bind(null_cb, 42));
 }
 
 }  // namespace
 }  // namespace base