Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2352833002: Revert of Changed sequence of package_build step (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index 63a9f3e2dee90a79d6801fa6bd2ae2aa389bab3b..941ce3a9fdcdbea24c41aefc2bcde916e30708c6 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -440,18 +440,6 @@
if not bot_config.get('cf_archive_build'):
master_config = bot_db.get_master_settings(mastername)
build_revision = update_step.presentation.properties['got_revision']
- self.m.archive.zip_and_upload_build(
- 'package build',
- self.m.chromium.c.build_config_fs,
- build_url=self._build_gs_archive_url(
- mastername, master_config, buildername),
- build_revision=build_revision,
- cros_board=self.m.chromium.c.TARGET_CROS_BOARD,
- # TODO(machenbach): Make asan a configuration switch.
- package_dsym_files=(
- self.m.chromium.c.gyp_env.GYP_DEFINES.get('asan') and
- self.m.chromium.c.HOST_PLATFORM == 'mac'),
- )
# For archiving 'chromium.perf', the builder also archives a version
# without perf test files for manual bisect.
@@ -469,6 +457,19 @@
store_by_hash=False,
platform=self.m.chromium.c.HOST_PLATFORM
)
+
+ self.m.archive.zip_and_upload_build(
+ 'package build',
+ self.m.chromium.c.build_config_fs,
+ build_url=self._build_gs_archive_url(
+ mastername, master_config, buildername),
+ build_revision=build_revision,
+ cros_board=self.m.chromium.c.TARGET_CROS_BOARD,
+ # TODO(machenbach): Make asan a configuration switch.
+ package_dsym_files=(
+ self.m.chromium.c.gyp_env.GYP_DEFINES.get('asan') and
+ self.m.chromium.c.HOST_PLATFORM == 'mac'),
+ )
trigger_specs = []
for loop_mastername, loop_buildername, builder_dict in sorted(
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698