Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2352833002: Revert of Changed sequence of package_build step (Closed)

Created:
4 years, 3 months ago by dtu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Changed sequence of package_build step (patchset #2 id:20001 of https://codereview.chromium.org/2335383002/ ) Reason for revert: Turns out this had an unintended side effect. The "package build" step sets the "build_archive_url" property, so now the perf testers are using the wrong build archive. First failing tests: https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf%20%282%29/builds/6824 https://build.chromium.org/p/chromium.perf/builders/Win%207%20Nvidia%20GPU%20Perf%20%282%29/builds/6913 Original issue's description: > Changed sequence of package_build step to be before package_build_for_bisect > > BUG=645662 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/2f0a7c064259dc0e0bf375c2d1771544f5647a1c TBR=prasadv@chromium.org,stip@chromium.org,mmoss@google.com,mmoss@chromium.org,miimnk@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645662 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8cde6a2835f03e5bf18e1bd8e84e8421dc206495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -96 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 2 chunks +13 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Linux_Builder.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Builder.json View 2 chunks +28 lines, -28 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_x64_Builder.json View 2 chunks +28 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dtu
Created Revert of Changed sequence of package_build step
4 years, 3 months ago (2016-09-19 19:08:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352833002/1
4 years, 3 months ago (2016-09-19 19:08:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/8cde6a2835f03e5bf18e1bd8e84e8421dc206495
4 years, 3 months ago (2016-09-19 19:12:45 UTC) #5
dtu
4 years, 3 months ago (2016-09-19 19:22:15 UTC) #6
Message was sent while issue was closed. 
On 2016/09/19 19:12:45, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/tools/build/+/8cde6a2835f03e5bf18e...

The bug for this is http://crbug.com/647894

Powered by Google App Engine
This is Rietveld 408576698