Force-generate a frame before the end of a layout test.

Force-generate a frame before the end of a layout test.

Previously, the layout tree and pixel dump could happen while the lifecycle
was dirty.

Committed: https://crrev.com/28f6beb118cd0d72d2d80cb15bd06c0b214ed792
Cr-Commit-Position: refs/heads/master@{#419919}

[chrishtr, 2016-09-19 23:49:10]

Description was changed from

==========
none

BUG=
==========

to

==========
Run any pending animations before the end of a layout test.

Previously, the layout tree and pixel dump happened while the lifecycle
was dirty.
==========

[chrishtr, 2016-09-19 23:49:20]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[chrishtr, 2016-09-19 23:49:24]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[chrishtr, 2016-09-19 23:49:38]

https://codereview.chromium.org/2352813004/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/blink_test_runner.cc (left):

https://codereview.chromium.org/2352813004/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/blink_test_runner.cc:882:
test_runner::LayoutAndPaintAsyncThen(
@wangxianzhu: this is no longer needed, right?

[commit-bot: I haz the power, 2016-09-19 23:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 00:00:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:00:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[chrishtr, 2016-09-20 00:02:31]

What I don't understand yet is why a bunch of tests were not failing before this
patch.
There must be more to the story...

[Xianzhu, 2016-09-20 02:40:35]

lgtm

https://codereview.chromium.org/2352813004/diff/1/content/shell/renderer/layo...
File content/shell/renderer/layout_test/blink_test_runner.cc (left):

https://codereview.chromium.org/2352813004/diff/1/content/shell/renderer/layo...
content/shell/renderer/layout_test/blink_test_runner.cc:882:
test_runner::LayoutAndPaintAsyncThen(
On 2016/09/19 23:49:38, chrishtr wrote:
> @wangxianzhu: this is no longer needed, right?

Right. This had been needed before sync painting.

[chrishtr, 2016-09-20 18:25:35]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 18:26:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-09-20 18:26:05]

Description was changed from

==========
Run any pending animations before the end of a layout test.

Previously, the layout tree and pixel dump happened while the lifecycle
was dirty.
==========

to

==========
Force-generate a frame before the end of a layout test.

Previously, the layout tree and pixel dump could happen while the lifecycle
was dirty.
==========

[commit-bot: I haz the power, 2016-09-20 19:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:27:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-09-20 22:56:14]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:57:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-09-20 23:45:08]

chrishtr@chromium.org changed reviewers:
+ piman@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:47:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:47:06]

Dry run: This issue passed the CQ dry run.

[piman, 2016-09-21 00:14:21]

lgtm

[chrishtr, 2016-09-21 00:26:43]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-09-21 00:26:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2352813004/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-09-21 00:27:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:34:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-21 00:36:07]

Description was changed from

==========
Force-generate a frame before the end of a layout test.

Previously, the layout tree and pixel dump could happen while the lifecycle
was dirty.
==========

to

==========
Force-generate a frame before the end of a layout test.

Previously, the layout tree and pixel dump could happen while the lifecycle
was dirty.

Committed: https://crrev.com/28f6beb118cd0d72d2d80cb15bd06c0b214ed792
Cr-Commit-Position: refs/heads/master@{#419919}
==========

[commit-bot: I haz the power, 2016-09-21 00:36:09]

Patchset 3 (id:??) landed as
https://crrev.com/28f6beb118cd0d72d2d80cb15bd06c0b214ed792
Cr-Commit-Position: refs/heads/master@{#419919}