Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2352813003: [Extensions DocServer]: More datastore API updates (Closed)

Created:
4 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions DocServer]: More datastore API updates Changes the datastore push logic to use the new gcloud datastore client library. BUG=646877 R=rdevlin.cronin@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/f209a86852187e5a7c9a2f99c8b98ffa92ca7c7a Cr-Commit-Position: refs/heads/master@{#419594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M chrome/common/extensions/docs/server2/datastore_util.py View 5 chunks +17 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Rockot(use gerrit already)
4 years, 3 months ago (2016-09-19 22:04:22 UTC) #2
Devlin
lgtm. To confirm, we don't need a version bump for this because 3.50.4 never actually ...
4 years, 3 months ago (2016-09-19 22:16:45 UTC) #3
Ken Rockot(use gerrit already)
Correct, no data in the datastore for that version, so it won't matter
4 years, 3 months ago (2016-09-19 22:19:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2352813003/1
4 years, 3 months ago (2016-09-19 22:21:10 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 22:35:47 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 22:37:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f209a86852187e5a7c9a2f99c8b98ffa92ca7c7a
Cr-Commit-Position: refs/heads/master@{#419594}

Powered by Google App Engine
This is Rietveld 408576698