Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2352813002: Filter out synthetic variables from with scopes (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Filter out synthetic variables from with scopes This patch ensures that variables like .new_target aren't overwritable using with scopes. It does this by ensuring that scope analysis does not consider with scopes (or eval scopes) for such 'synthetic variables', similarly to how the 'this' variable was already handled. The patch also adds a DCHECK for the dynamic parallel to this case, replacing a previous unreachable path for a particular instance. BUG=v8:5405

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -14 lines) Patch
M src/ast/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/contexts.cc View 2 chunks +13 lines, -13 lines 0 comments Download
A test/mjsunit/regress/regress-5405.js View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698