Don't use path expansion for profile dictionaries in LocalState

chrome/browser/prefs/pref_metrics_service_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/statistics_recorder.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/pref_metrics_service.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
+#include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_pref_service_syncable.h"
 #include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/testing_profile_manager.h"
 #include "components/user_prefs/pref_registry_syncable.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // TestingProfile may register some real preferences; to avoid interference,
 // define fake preferences for testing.
 const char* kTrackedPrefs[] = {
   "pref_metrics_service_test.pref1",
   "pref_metrics_service_test.pref2",
@@ skipping 10 matching lines @@
     pref2_changed_ = 0;
     pref1_cleared_ = 0;
     pref2_cleared_ = 0;
     pref1_initialized_ = 0;
     pref2_initialized_ = 0;
     pref1_unchanged_ = 0;
     pref2_unchanged_ = 0;
 
     base::StatisticsRecorder::Initialize();
 
-    prefs_ = profile_.GetTestingPrefService();
+    // Reset and set up the profile manager.
+    profile_manager_.reset(new TestingProfileManager(
+        TestingBrowserProcess::GetGlobal()));
+    ASSERT_TRUE(profile_manager_->SetUp());
+
+    // Check that PrefMetricsService behaves with a '.' in the profile name.
+    profile_ = profile_manager_->CreateTestingProfile("test@example.com");
+
+    prefs_ = profile_->GetTestingPrefService();
 
     // Register our test-only tracked prefs as string values.
     for (int i = 0; i < kTrackedPrefCount; ++i) {
       prefs_->registry()->RegisterStringPref(
           kTrackedPrefs[i],
           "test_default_value",
           user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
     }
 
     // Initialize pref in local state that holds hashed values.
     PrefMetricsService::RegisterPrefs(local_state_.registry());
 
     // Update global counts in case another test left stray samples.
     UpdateHistogramSamples();
   }
 
   scoped_ptr<PrefMetricsService> CreatePrefMetricsService() {
     return scoped_ptr<PrefMetricsService>(
-        new PrefMetricsService(&profile_,
+        new PrefMetricsService(profile_,
                                &local_state_,
                                "test_device_id",
                                kTrackedPrefs,
                                kTrackedPrefCount));
   }
 
   std::string GetHashedPrefValue(PrefMetricsService* service,
                                  const char* path, base::Value* value) {
     return service->GetHashedPrefValue(path, value);
   }
@@ skipping 34 matching lines @@
     pref2_initialized_total = inited2;
 
     int unchanged1, unchanged2;
     GetSamples("Settings.TrackedPreferenceUnchanged", &unchanged1, &unchanged2);
     pref1_unchanged_ = unchanged1 - pref1_unchanged_total;
     pref2_unchanged_ = unchanged2 - pref2_unchanged_total;
     pref1_unchanged_total = unchanged1;
     pref2_unchanged_total = unchanged2;
   }
 
-  TestingProfile profile_;
+  TestingProfile* profile_;
+  scoped_ptr<TestingProfileManager> profile_manager_;
   TestingPrefServiceSyncable* prefs_;
   TestingPrefServiceSimple local_state_;
 
   // Since histogram samples are recorded by a global StatisticsRecorder, we
   // need to maintain total counts so we can compute deltas for individual
   // tests.
   static int pref1_changed_total;
   static int pref2_changed_total;
   static int pref1_cleared_total;
   static int pref2_cleared_total;
@@ skipping 136 matching lines @@
   EXPECT_EQ("C503FB7C65EEFD5C07185F616A0AA67923C069909933F362022B1F187E73E9A2",
             GetHashedPrefValue(test.get(), "pref.path1", &dict));
 
   ListValue list;
   list.Set(0, new base::FundamentalValue(true));
   list.Set(1, new base::FundamentalValue(100));
   list.Set(2, new base::FundamentalValue(1.0));
   EXPECT_EQ("3163EC3C96263143AF83EA5C9860DFB960EE2263413C7D7D8A9973FCC00E7692",
             GetHashedPrefValue(test.get(), "pref.path2", &list));
 }