Don't use path expansion for profile dictionaries in LocalState

chrome/browser/profiles/profile_info_cache_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_info_cache_unittest.h"
 
+#include <vector>
+
 #include "base/prefs/testing_pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "content/public/browser/notification_observer.h"
@@ skipping 435 matching lines @@
       managed_user_name, 0, "TEST_ID");
   for (size_t i = 0; i < GetCache()->GetNumberOfProfiles(); i++) {
     bool is_managed =
         GetCache()->GetNameOfProfileAtIndex(i) == managed_user_name;
     EXPECT_EQ(is_managed, GetCache()->ProfileIsManagedAtIndex(i));
     std::string managed_user_id = is_managed ? "TEST_ID" : "";
     EXPECT_EQ(managed_user_id, GetCache()->GetManagedUserIdOfProfileAtIndex(i));
   }
 }
 
+TEST_F(ProfileInfoCacheTest, AddStubProfile) {
+  EXPECT_EQ(0u, GetCache()->GetNumberOfProfiles());
+
+  // Add some profiles with and without a '.' in their paths.
+  for (uint32 i = 0; i < 4; ++i) {
+    base::FilePath profile_path =
+        GetProfilePath(base::StringPrintf("path%ctest%u",
+                                          i % 2 ? '_' : '.',
+                                          i));
+    string16 profile_name = ASCIIToUTF16(base::StringPrintf("name_%u", i));

[xiyuan, 2013/09/14 18:39:56]

nit: It's easier to read if we put the profile_path and profile_name into a test
case struct array.

e.g.

struct  {
  char* profile_path;
  char* profile_name;
} kTestCases[] = {
  { "path.ctest0", "name_0" },
  { "path_ctest1", "name_1" },
  { "path.ctest2", "name_2" },
  { "path_ctest3", "name_3" },
};

for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kTestCases); ++i) {
  base::FilePath profile_path(kTestCases[i].profile_path);
  string16 profile_name = ASCIIToUTF16(kTestCases[i].profile_name);
  ...
}

[michaelpg, 2013/09/14 19:30:24]

Done.

+
+    GetCache()->AddProfileToCache(profile_path, profile_name, string16(), i,
+                                  "");
+
+    EXPECT_EQ(profile_path, GetCache()->GetPathOfProfileAtIndex(i));
+    EXPECT_EQ(profile_name, GetCache()->GetNameOfProfileAtIndex(i));
+  }
+
+  ASSERT_EQ(4U, GetCache()->GetNumberOfProfiles());
+
+  // Check that the profiles can be extracted from the local state.
+  std::vector<string16> names = ProfileInfoCache::GetProfileNames();
+  for (size_t i = 0; i < 4; i++)
+    ASSERT_FALSE(names[i].empty());
+}
+
 }  // namespace