Issue 23528005: Revert "Remove ShouldSetAttached flag to lazyAttach"

Issue 23528005: Revert "Remove ShouldSetAttached flag to lazyAttach" (Closed)

Created:
7 years, 3 months ago by eustas

Modified:
7 years, 3 months ago

Reviewers:
esprehn

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Remove ShouldSetAttached flag to lazyAttach" This reverts commit dfc6e91da01f3573f34d386c1c7db40838db7296. Gardening: this change caused crashes in editing/style/iframe-onload-crash-XXX.html BUG= TBR=esprehn@chromium.org

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+14 lines, -8 lines)			Patch
Source/core/dom/Node.h	View	3 chunks	+8 lines, -4 lines	0 comments	Download
Source/core/dom/Node.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download
Source/core/html/HTMLFrameElementBase.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

esprehn

This was landed as http://src.chromium.org/viewvc/blink/?view=revision&revision=157445

7 years, 3 months ago (2013-09-10 09:08:03 UTC) #1

esprehn

On 2013/09/10 09:08:03, esprehn wrote: > This was landed as > http://src.chromium.org/viewvc/blink/?view=revision&revision=157445 See crashes that ...

7 years, 3 months ago (2013-09-10 09:10:51 UTC) #2

esprehn

7 years, 3 months ago (2013-09-10 09:13:46 UTC) #3

Message was sent while issue was closed.

On 2013/09/10 09:10:51, esprehn wrote:
> On 2013/09/10 09:08:03, esprehn wrote:
> > This was landed as
> > http://src.chromium.org/viewvc/blink/?view=revision&revision=157445
> 
> See crashes that started in debug here:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=edi...

STDERR: ASSERTION FAILED: !child->attached() ||
childAttachedAllowedWhenAttachingChildren(this)

STDERR:  [0x7f0cc7c2a9aa] WebCore::ContainerNode::attachChildren()
STDERR:  [0x7f0cc7c2893b] WebCore::ContainerNode::attach()
STDERR:  [0x7f0cc7ca2150] WebCore::Element::attach()
STDERR:  [0x7f0cc7c2a9e5] WebCore::ContainerNode::attachChildren()
STDERR:  [0x7f0cc7c2893b] WebCore::ContainerNode::attach()
STDERR:  [0x7f0cc7ca2150] WebCore::Element::attach()
STDERR:  [0x7f0cc911f2b4] WebCore::HTMLFormControlElement::attach()
STDERR:  [0x7f0cc7cf5cc6] WebCore::Node::reattach()
STDERR:  [0x7f0cc7ca2c03] WebCore::Element::recalcOwnStyle()
STDERR:  [0x7f0cc7ca2a49] WebCore::Element::recalcStyle()
STDERR:  [0x7f0cc7ca314f] WebCore::Element::recalcChildStyle()
STDERR:  [0x7f0cc7ca2a65] WebCore::Element::recalcStyle()
STDERR:  [0x7f0cc7ca314f] WebCore::Element::recalcChildStyle()
STDERR:  [0x7f0cc7ca2a65] WebCore::Element::recalcStyle()
STDERR:  [0x7f0cc7ca314f] WebCore::Element::recalcChildStyle()
STDERR:  [0x7f0cc7ca2a65] WebCore::Element::recalcStyle()
STDERR:  [0x7f0cc7ca314f] WebCore::Element::recalcChildStyle()
STDERR:  [0x7f0cc7ca2a65] WebCore::Element::recalcStyle()
STDERR:  [0x7f0cc7c5b015] WebCore::Document::recalcStyle()
STDERR:  [0x7f0cc7c5b3c0] WebCore::Document::updateStyleIfNeeded()
STDERR:  [0x7f0cc7c64bde] WebCore::command()
STDERR:  [0x7f0cc7c64c4e] WebCore::Document::execCommand()
STDERR:  [0x7f0cc8db3f5d] WebCore::DocumentV8Internal::execCommandMethod()

Expand Messages | Collapse Messages